Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace outdated esrv id link #7438

Merged

Conversation

kevin9foong
Copy link
Contributor

@kevin9foong kevin9foong commented Jun 25, 2024

Problem

Currently, for admin to get their eservice id, it says to email [email protected] but it should be http://partnersupport.singpass.gov.sg/ instead.

Closes FRM-1754

Solution

Update the text to the correct website link.

Breaking Changes

  • No - this PR is backwards compatible

Before & After Screenshots

Topic Before After
eSrvIdBox help message image image

Tests

helper text displays message as intended

  • Create form and go to admin auth settings page
  • Select singpass authtype
  • Check that the new message is as shown as screenshot. (Ie. Singpass support partner...)
  • Repeat for SP with Myinfo & Corppass

Copy link

linear bot commented Jun 25, 2024

@kevin9foong kevin9foong force-pushed the chore/change-singpass-eservice-partner-support-contact branch from 1028653 to b26f44c Compare June 25, 2024 07:49
@kevin9foong kevin9foong requested review from KenLSM and g-tejas June 25, 2024 07:49
@kevin9foong kevin9foong requested a review from g-tejas June 25, 2024 10:20
@kevin9foong kevin9foong self-assigned this Jun 25, 2024
Copy link
Contributor

@KenLSM KenLSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kevin9foong kevin9foong merged commit c6ba38d into develop Jun 26, 2024
21 of 22 checks passed
@kevin9foong kevin9foong deleted the chore/change-singpass-eservice-partner-support-contact branch June 26, 2024 08:46
@KenLSM KenLSM mentioned this pull request Jun 30, 2024
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants